Generate latest thumbnail image for each segment #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
===============================================
+ Coverage 0 17.48252% +17.48252%
===============================================
Files 0 2 +2
Lines 0 143 +143
===============================================
+ Hits 0 25 +25
- Misses 0 109 +109
- Partials 0 9 +9
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
thomshutt
reviewed
Oct 18, 2023
core/uploader.go
Outdated
| defer f.Close() | ||
| _, err = session.SaveData(context.Background(), "../latest.jpg", f, &drivers.FileProperties{CacheControl: "max-age=5"}, 1*time.Minute) | ||
| if err != nil { | ||
| log.Printf("Saving thumbnail failed: %s", err) |
There was a problem hiding this comment.
Let's get some context on these log lines so we can correlate to a particular upload URL
thomshutt
approved these changes
Oct 20, 2023
core/uploader.go
Outdated
| func extractThumb(uri string, session drivers.OSSession) { | ||
| presigned, err := session.Presign("", 5*time.Minute) | ||
| if err != nil { | ||
| log.Printf("Presigning failed for %s: %s", uri, err) |
There was a problem hiding this comment.
You could have this method return an error and then just log that (and add the URI context at that top level)
There was a problem hiding this comment.
yes that would make a lot more sense :)
This reverts commit 2bc1688.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.